Bug #22473

WeiDU APPENDing to tooltip.2da should not crash the game

Added by Petr "Pecca" Havlicek over 3 years ago. Updated about 3 years ago.

Status:Closed - FixedStart date:04/06/2016
Classification:C - MinorDue date:
Assignee:-% Done:

100%

Category:-
Target version:Public Bug Reports - 2.2.66.0
Found In Version:Public Bug Reports - 2.0.62.2

Description

  1. Download the attached mod and install the first component.
  2. Start the game.

Observed

The game crashes.

Expected

The game shouldn't crash.

Notes

See below. Basically, the extra spaces at EOF cause WeiDU to misuse APPEND, which in turn causes SoD to freak out and crash. The second component fixes the issue and identifies other text files with the same issue.

00806.zip (866 KB) Pete Camagna, "CamDawg", 04/06/2016 05:01 PM

History

#1 Updated by Pete Camagna, "CamDawg" over 3 years ago

Confirmed, but for different reasons. WeiDU can handle files with linebreaks at the end--in fact it adds an ending linebreak when it APPENDs--the problem here are ending spaces.

The last line of the file actually contains spaces, so an APPEND command handed to WeiDU will skip the last line. It's the gap that cause the crash.

I've attached a small mod that lets you see the issue in action by APPENDing to tooltip.2da (component 1). After installing this, the game should crahs as in the original report. The second component fixes the issue and then APPENDs, which works as expected. It will also identify other files with this issue.

#2 Updated by Pete Camagna, "CamDawg" over 3 years ago

  • Description updated (diff)

The original bug report from Pecca is below. I've rewritten the repro steps.

1. Open Tooltip.2da file with Near Infinity
2. See that there is an empty line (number 48)

Observed
This empty line causes the game crash on launch, when tooltip.2da is patched by WeiDU. Deleting this line fixes the problem.

Expected
There shouldn't be an empty line at the bottom of tooltip.2da file

#3 Updated by Pete Camagna, "CamDawg" over 3 years ago

  • Subject changed from Tooltip.2da file should not have an empty line at the bottom to WeiDU APPENDing to tooltip.2da should not crash the game

Internal bug report #22499.

#4 Updated by Filip Flechtner over 3 years ago

  • Status changed from New to Submitted

#5 Updated by Richard Hilton about 3 years ago

  • Target version set to Next Update

#6 Updated by Filip Flechtner about 3 years ago

  • Status changed from Submitted to Closed - Fixed
  • % Done changed from 0 to 100

Fixed in v2.2.64.1.

#7 Updated by Jeff "Cerevant" Payne about 3 years ago

  • Target version changed from Next Update to 2.2.66.0

Also available in: Atom PDF